feat(payment): payment and session methods #6138

fPolic · 2024-01-19T17:52:52Z

What

create PaymentSession
create/update Payment
refund/capture Payment
DTOs update
change signatures of some Payment module methods

Note

please ignore changes related to computing and decorating amount properties since the approach will change in the future so it's still TODO

…e-payment-collection-crud

# Conflicts: # packages/types/src/payment/mutations.ts

changeset-bot · 2024-01-19T17:52:57Z

⚠️ No Changeset found

Latest commit: 11e60bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-01-19T17:53:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2024 6:52pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)		Feb 5, 2024 6:52pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Feb 5, 2024 6:52pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 5, 2024 6:52pm

# Conflicts: # packages/payment/integration-tests/__tests__/services/payment-module/index.spec.ts # packages/payment/src/loaders/container.ts # packages/payment/src/services/payment-module.ts # packages/types/src/payment/mutations.ts

# Conflicts: # packages/payment/integration-tests/__tests__/services/payment-module/index.spec.ts

packages/types/src/payment/mutations.ts

packages/payment/src/services/payment-module.ts

packages/payment/src/models/payment.ts

packages/payment/src/services/payment.ts

packages/payment/src/services/payment-module.ts

# Conflicts: # packages/payment/integration-tests/__tests__/services/payment-module/index.spec.ts # packages/payment/src/services/index.ts # packages/payment/src/services/payment-module.ts # packages/payment/src/types/repositories.ts

olivermrbl · 2024-02-06T10:54:55Z

@carlos-r-l-rodrigues, can I get you to give this a review? Would like your eyes on the bulk methods for payment collections. Think some of them can get a bit nasty, especially when we introduce several calls to a third party provider.

carlos-r-l-rodrigues · 2024-02-06T11:56:40Z

@carlos-r-l-rodrigues, can I get you to give this a review? Would like your eyes on the bulk methods for payment collections. Think some of them can get a bit nasty, especially when we introduce several calls to a third party provider.

This is tricky, I told @fPolic that we could have bulk operations for that, but in a second thought I think that when we involve the providers the methods have to be single operations.
We can create sessions in bulk tho, but authorizing, capturing and refunding are harder to manage when a partial error happens. We revert everything on our side but we can't revert from the provider.
Call them in parallel or not is decision to make when implementing it.

olivermrbl · 2024-02-06T12:39:17Z

I agree this is a tricky case. Right now, I am also leaning toward single operations. Let's discuss and address it in your follow up PR @fPolic that contains the provider implementation.

fPolic added 19 commits January 17, 2024 09:42

wip: setup

3cf8365

Merge branch 'feat/payment-module-interfaces' into feat/payment-modul…

ac1c083

…e-payment-collection-crud

feat: create

b83ef41

Merge branch 'feat/payment-module-interfaces' into feat/payment-modul…

7b20a7d

…e-payment-collection-crud

feat: delete PC

426d609

fix; param

71d5d8f

feat: list methods

fee5e19

feat: update, list, tests wip

d00fc3c

feat: list tests

66044a5

feat: update, retrieve, tests

8cf8581

Merge branch 'develop' into feat/payment-module-payment-collection-crud

7c90f75

# Conflicts: # packages/types/src/payment/mutations.ts

refactor: use abstract service

b1c9851

fix: add missing props for update

ebd8ea6

fix: move enum

9fd4715

chore: import

c7da017

wip: Payment and PaymentSession services, creation of entities and tests

083ca5f

feat: create Session and Payment

f430524

wip: update Payment

045c27e

wip: Refund & Capture

5e69650

Base automatically changed from feat/payment-module-payment-collection-crud to develop January 22, 2024 10:04

fix: create, refactor model, finalise test

172a5e0

vercel bot deployed to Preview – medusa-dashboard January 22, 2024 10:45 View deployment

fix: tests

c1a20af

vercel bot deployed to Preview – medusa-dashboard January 22, 2024 12:13 View deployment

feat: Capture/Refund and tests

1ce795e

vercel bot deployed to Preview – medusa-dashboard January 22, 2024 13:51 View deployment

vercel bot deployed to Preview – medusa-dashboard January 22, 2024 13:56 View deployment

fPolic added 2 commits January 25, 2024 09:57

Merge branch 'develop' into feat/payment-module-payment-and-session-crud

beea4ae

# Conflicts: # packages/payment/integration-tests/__tests__/services/payment-module/index.spec.ts

fix: conflicts

918bb38

vercel bot deployed to Preview – medusa-dashboard January 25, 2024 09:04 View deployment

fPolic added 2 commits January 25, 2024 12:05

feat: capture bulk

c98844a

feat: refund bulk

3d81950

vercel bot deployed to Preview – medusa-dashboard January 25, 2024 13:17 View deployment

fix: payment service test

facf7f8

vercel bot deployed to Preview – medusa-dashboard January 25, 2024 13:26 View deployment

Merge branch 'develop' into feat/payment-module-payment-and-session-crud

082b4c0

# Conflicts: # packages/payment/integration-tests/__tests__/services/payment-module/index.spec.ts

github-actions bot added the team: medusa label Feb 2, 2024

vercel bot deployed to Preview – medusa-dashboard February 2, 2024 09:32 View deployment

olivermrbl requested changes Feb 5, 2024

View reviewed changes

fPolic added 2 commits February 5, 2024 13:28

chore: migrate to new abstract service

75468c8

vercel bot deployed to Preview – medusa-dashboard February 5, 2024 15:06 View deployment

fix: address comments

a17609e

vercel bot deployed to Preview – medusa-dashboard February 5, 2024 15:39 View deployment

fPolic and others added 2 commits February 5, 2024 18:50

refactor: remove payment service

81ac0cc

Merge branch 'develop' into feat/payment-module-payment-and-session-crud

ddbde24

vercel bot deployed to Preview – medusa-dashboard February 5, 2024 17:54 View deployment

fix: revisit DTOs, add todos

c1dea05

vercel bot deployed to Preview – medusa-dashboard February 5, 2024 18:04 View deployment

fix: build

11e60bf

vercel bot deployed to Preview – medusa-dashboard February 5, 2024 18:52 View deployment

olivermrbl approved these changes Feb 6, 2024

View reviewed changes

olivermrbl merged commit 2104843 into develop Feb 6, 2024
17 checks passed

olivermrbl deleted the feat/payment-module-payment-and-session-crud branch February 6, 2024 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(payment): payment and session methods #6138

feat(payment): payment and session methods #6138

fPolic commented Jan 19, 2024 •

edited

Loading

changeset-bot bot commented Jan 19, 2024 •

edited

Loading

vercel bot commented Jan 19, 2024 •

edited

Loading

olivermrbl commented Feb 6, 2024

carlos-r-l-rodrigues commented Feb 6, 2024 •

edited

Loading

olivermrbl commented Feb 6, 2024

feat(payment): payment and session methods #6138

feat(payment): payment and session methods #6138

Conversation

fPolic commented Jan 19, 2024 • edited Loading

changeset-bot bot commented Jan 19, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Jan 19, 2024 • edited Loading

olivermrbl commented Feb 6, 2024

carlos-r-l-rodrigues commented Feb 6, 2024 • edited Loading

olivermrbl commented Feb 6, 2024

fPolic commented Jan 19, 2024 •

edited

Loading

changeset-bot bot commented Jan 19, 2024 •

edited

Loading

vercel bot commented Jan 19, 2024 •

edited

Loading

carlos-r-l-rodrigues commented Feb 6, 2024 •

edited

Loading