feat(auth): add authentication endpoints #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update datamodel * update scope handlers * add index migration * fix integration tests * fix integration tests
riqwan
approved these changes
Feb 1, 2024
packages/medusa/src/api-v2/auth/[scope]/[authProvider]/callback/route.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const { success, error, authUser, location } = authResult | ||
| if (location) { | ||
| res.redirect(location) |
There was a problem hiding this comment.
question: shouldn't the client be the one doing the redirect?
Co-authored-by: Riqwan Thamir <[email protected]>
Co-authored-by: Riqwan Thamir <[email protected]>
adrien2p
reviewed
Feb 1, 2024
packages/medusa/src/api-v2/auth/[scope]/[authProvider]/callback/route.ts
Outdated
Show resolved
Hide resolved
| const authResult = await service.validateCallback(authProvider, authData) | ||
|
|
||
| const { success, error, authUser, location } = authResult | ||
| if (location) { |
There was a problem hiding this comment.
if there is a location (the redirect could be configured) then we don't check any success or failure?
There was a problem hiding this comment.
yes, we could validate to ensure that success is required if you think that's appropriate? 😄 just figured that in case of a redirect you would want that no matter what
There was a problem hiding this comment.
in general you have a success redirect and a failure redirect that eventually could have custom query parameters, let see that later
olivermrbl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/auth/[scope]/[provider]/auth/[scope]/[provider]/callbacknote: there's still some remaining work related to jwt auth to be handled, this is mainly focussed on session auth with endpoints