Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Use remote query in get cart API route #6285

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat(medusa): Use remote query in get cart API route #6285

merged 2 commits into from
Jan 31, 2024

Conversation

olivermrbl
Copy link
Contributor

  • remove unused joiner configs from core

@olivermrbl olivermrbl marked this pull request as ready for review January 31, 2024 15:05
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8d9e7e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl requested review from a team as code owners January 31, 2024 15:05
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:16pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 31, 2024 3:16pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:16pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:16pm

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to also remove isInternalService: true from cart-sales-channels.ts

@olivermrbl olivermrbl merged commit d5e4707 into develop Jan 31, 2024
17 checks passed
@olivermrbl olivermrbl deleted the feat/rq-get-cart branch January 31, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @carlos-r-l-rodrigues