Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Make token auth default #6305

Merged
merged 90 commits into from
Feb 5, 2024
Merged

feat(auth): Make token auth default #6305

merged 90 commits into from
Feb 5, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Feb 2, 2024

What

  • make token auth the default being returned from authentication endpoints in api-v2
  • Add auth/session to convert token to session based auth
  • add regex-scopes to authenticate middleware

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 66f0edb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 5:42am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 5, 2024 5:42am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:42am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:42am

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs to rebase on develop and fix tests.

@srindom srindom changed the base branch from feat/add-authentication-endpoints-for-v2 to develop February 2, 2024 14:52
@pKorsholm pKorsholm changed the title token auth init feat(auth): Make token auth default Feb 5, 2024
@srindom
Copy link
Collaborator

srindom commented Feb 5, 2024

@pKorsholm - let's merge this and get #6314 in after 👍

@kodiakhq kodiakhq bot merged commit e2738ab into develop Feb 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants