feat: Region Module (basic CRUD) #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
srindom
approved these changes
Feb 5, 2024
adrien2p
reviewed
Feb 5, 2024
packages/region/integration-tests/__tests__/services/region-module.spec.ts
Outdated
Show resolved
Hide resolved
packages/region/integration-tests/__tests__/services/region-module.spec.ts
Outdated
Show resolved
Hide resolved
packages/region/integration-tests/__tests__/services/region-module.spec.ts
Outdated
Show resolved
Hide resolved
| data: CreateRegionDTO | CreateRegionDTO[], | ||
| @MedusaContext() sharedContext: Context = {} | ||
| ): Promise<RegionDTO | RegionDTO[]> { | ||
| const input = Array.isArray(data) ? data : [data] |
There was a problem hiding this comment.
suggestion: same as for phil, as you like
Comment on lines
+162
to
+166
| return await this.baseRepository_.serialize<RegionDTO[]>( | ||
| Array.isArray(data) ? result : result[0], | ||
| { | ||
| populate: true, | ||
| } |
There was a problem hiding this comment.
suggestion: same as above, phil open a pr for the update, I forgot in the base class
olivermrbl
force-pushed
the
feat/region-module
branch
from
10d26c5 to
47065e6
Compare
olivermrbl
force-pushed
the
feat/region-module
branch
from
47065e6 to
27946af
Compare
olivermrbl
force-pushed
the
feat/region-module
branch
from
27946af to
4526c15
Compare
adrien2p
force-pushed
the
feat/region-module
branch
from
b77f6c1 to
64c497c
Compare
olivermrbl
force-pushed
the
feat/region-module
branch
from
3e3d62b to
09e1bc2
Compare
olivermrbl
force-pushed
the
feat/region-module
branch
from
09e1bc2 to
2680d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.