Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: s3 The "images.domains" configuration is deprecated #6321

Merged
merged 3 commits into from
Feb 6, 2024
Merged

docs: s3 The "images.domains" configuration is deprecated #6321

merged 3 commits into from
Feb 6, 2024

Conversation

xyzones
Copy link
Contributor

@xyzones xyzones commented Feb 5, 2024

No description provided.

@xyzones xyzones requested a review from a team as a code owner February 5, 2024 18:22
Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: ef70693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 5, 2024

@xyzones is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can I get you to make the same change for the other storage services (MinIO, DigitalOcean Spaces, etc...)?

@xyzones xyzones requested a review from shahednasser February 6, 2024 08:33
@xyzones
Copy link
Contributor Author

xyzones commented Feb 6, 2024

@shahednasser i have added them

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution

@kodiakhq kodiakhq bot merged commit 5cabe95 into medusajs:develop Feb 6, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants