Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export public structures for better import path #493

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Re-export public structures for better import path #493

merged 2 commits into from
Jul 18, 2023

Conversation

adriantombu
Copy link
Contributor

Pull Request

Related issue

Fixes #246

What does this PR do?

  • I think the PR title is already self-explanatory 😄

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot 🙏

@bidoubiwa bidoubiwa added the enhancement New feature or request label Jul 18, 2023
bidoubiwa
bidoubiwa approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 18, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 039ad9d into meilisearch:main Jul 18, 2023
5 checks passed
@adriantombu adriantombu deleted the 246-better-import-path branch July 18, 2023 12:04
@curquiza curquiza mentioned this pull request Sep 12, 2023
Merged
meili-bors bot added a commit that referenced this pull request Sep 12, 2023
@meili-bors @curquiza
Merge #519
7dd3bd2 
519: Update version for v0.24.2 r=curquiza a=curquiza

## 🚀 Enhancements

* Re-export public structures for better import path (#493) `@adriantombu`
* Added function for sending NDJSON documents (#494) `@carlosb1`
* Add missing startedAt field in EnqueuedTask (#485) `@sebastiantoh`
* #499 (attributesToSearchOn) (#510) `@brendon-shf`
* Add total field to get-tasks route (#509) `@hmacr`
* Implement client for experimental-features API (#516) `@hmacr`


Co-authored-by: curquiza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better import path
2 participants
@adriantombu @bidoubiwa