Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed no_run code in doctest #574

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Removed no_run code in doctest #574

merged 2 commits into from
Apr 18, 2024

Conversation

NoodleSamaChan
Copy link
Contributor

Pull Request

What does this PR do?

  • removes a few lines of unnecessary code from dumps and snapshots files for better upkeep

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@irevoire irevoire changed the title Removed unnecessary code in dumps and snapshots Removed no_run code in doctest Apr 18, 2024
irevoire
irevoire approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NoodleSamaChan
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Apr 18, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 76fb43f into meilisearch:main Apr 18, 2024
7 checks passed
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoodleSamaChan @irevoire @curquiza