OZ-689: Add functionality to remove transfer_encoding header and handle response status code in DelegatingController
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the response
…propriate response status code
wluyima
reviewed
Oct 10, 2024
| /** | ||
| * Provides a proxy mechanism for all GET requests for ChargeItemDefinition and InventoryItem FHIR | ||
| * resources by delegating to a configured external API to process the request. | ||
| */ | ||
| @Slf4j |
There was a problem hiding this comment.
I actually don't like using lombok to generate loggers, because they are anti pattern, as in they are in lower case.
wluyima
reviewed
Oct 10, 2024
omod/src/main/java/org/openmrs/module/fhirproxy/web/controller/DelegatingController.java
Outdated
Show resolved
Hide resolved
wluyima
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://mekomsolutions.atlassian.net/jira/software/c/projects/OZ/issues/OZ-689
This PR does;