Skip to content

Commit

Permalink
fix(taps): Check replication method instead of key to determine if a …
Browse files Browse the repository at this point in the history
…SQL stream is sorted (#2418)
  • Loading branch information
edgarrmondragon authored Jul 30, 2024
1 parent 5d66569 commit cb163bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions singer_sdk/streams/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import singer_sdk.helpers._catalog as catalog
from singer_sdk._singerlib import CatalogEntry, MetadataMapping
from singer_sdk.connectors import SQLConnector
from singer_sdk.streams.core import Stream
from singer_sdk.streams.core import REPLICATION_INCREMENTAL, Stream

if t.TYPE_CHECKING:
from singer_sdk.helpers.types import Context
Expand Down Expand Up @@ -227,7 +227,7 @@ def is_sorted(self) -> bool:
Returns:
`True` if stream is sorted. Defaults to `False`.
"""
return self.replication_key is not None
return self.replication_method == REPLICATION_INCREMENTAL


__all__ = ["SQLConnector", "SQLStream"]

0 comments on commit cb163bf

Please sign in to comment.