Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Settings write-back #2346

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

feat: Settings write-back

f098bcf
Select commit
Loading
Failed to load commit list.
Draft

feat: Settings write-back #2346

feat: Settings write-back
f098bcf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 7, 2024 in 1s

89.23% (+0.05%) compared to 9d0c08b

View this Pull Request on Codecov

89.23% (+0.05%) compared to 9d0c08b

Details

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (9d0c08b) to head (f098bcf).
Report is 80 commits behind head on main.

Files Patch % Lines
singer_sdk/plugin_base.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   89.18%   89.23%   +0.05%     
==========================================
  Files          54       54              
  Lines        4788     4794       +6     
  Branches      936      936              
==========================================
+ Hits         4270     4278       +8     
+ Misses        361      359       -2     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.