Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid write empty state #2844

Merged
merged 10 commits into from
Jan 29, 2025
+34 −57
Merged

fix: Avoid write empty state #2844

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
129a817
Avoid write empty state
joaopamaral Jan 28, 2025
f9f0943
Avoid write empty state
joaopamaral Jan 28, 2025
361252b
test
joaopamaral Jan 28, 2025
acb0756
revert test
joaopamaral Jan 28, 2025
3ae6dba
test
joaopamaral Jan 28, 2025
29683f9
test
joaopamaral Jan 28, 2025
12a70d8
test
joaopamaral Jan 28, 2025
f485d3e
adjust tests
joaopamaral Jan 29, 2025
5939ff6
adjust tests
joaopamaral Jan 29, 2025
b713e23
Update tests/samples/test_target_sqlite.py
joaopamaral Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert test
@joaopamaral
joaopamaral committed Jan 28, 2025
commit acb0756d2596f502bcc965a397f823de0de5daca
2 changes: 1 addition & 1 deletion singer_sdk/streams/core.py
View file
Original file line number Diff line number Diff line change
@@ -817,7 +817,7 @@ def _increment_stream_state(

def _write_state_message(self) -> None:
"""Write out a STATE message with the latest state."""
if (not self._is_state_flushed) and (
if (not self._is_state_flushed) and self.tap_state and (
self.tap_state != self._last_emitted_state
):
self._tap.write_message(singer.StateMessage(value=self.tap_state))