Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: set ff.env_var_strict_mode to true #312

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Jul 21, 2022

@pnadolny13 - We're considering making this the default behavior in a future release. Do you mind testing for us in squared?

This was based on your request to provide a way to set required env vars.

@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:46 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:46 Inactive
@aaronsteers aaronsteers changed the title change: ff.env_var_strict_mode: true change: set ff.env_var_strict_mode to true Jul 21, 2022
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:47 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:47 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:50 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:54 Inactive
@aaronsteers aaronsteers temporarily deployed to test July 21, 2022 01:59 Inactive
@pnadolny13
Copy link
Contributor

@aaronsteers oh nice! I found the issue also meltano/meltano#3348 to refresh my memory. Thanks I'll give it a try.

@pnadolny13
Copy link
Contributor

@aaronsteers I'm not able to get this to work. On main I tried removing this USER_PREFIX to see it fail because its used by dbt-snowflake when I run meltano --log-level=debug invoke dbt-snowflake:test but instead of getting an error related to USER_PREFIX missing I get:

18:49:58  Encountered an error:
Parsing Error
  Env var required but not provided: 'DBT_SNOWFLAKE_USER'

I confirmed that after adding an underscore like this it no longer throws this error because the DBT_SNOWFLAKE_USER value renders as just the underscore which is valid but the nothing about USER_PREFIX gets raised:

      transformers:
      - name: dbt-snowflake
        config:
          user: ${USER_PREFIX}_

Is there something else I should try or could there be a bug? I was expecting it to complain about USER_PREFIX not being set. Any ideas for me?

cc @cjohnhanson

@cjohnhanson
Copy link

@pnadolny13 This should be resolved now, let me know if you continue to have issues.

@aaronsteers
Copy link
Contributor Author

@pnadolny13 - Per @cjohnhanson's comments above, and per the related comment in #354, can you let us know if the latest version of Meltano resolves this, and if so, can we merge in this PR?

@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:21 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:21 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:21 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 25, 2022 22:25 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 31, 2022 21:26 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 31, 2022 21:26 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 31, 2022 21:33 Inactive
@aaronsteers aaronsteers temporarily deployed to test August 31, 2022 21:38 Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:20 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:20 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:20 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:25 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:30 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:30 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:30 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:35 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test December 16, 2022 18:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants