Minor improvements, prompt adjustments #2179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refer to "new generated facts" rather than "new retrieved facts"
because they are being generated by the LLM, not retrieved.
- Clarify that the `add()` method does more than add: it may actually
result in adds, updates, or deletes.
- No longer ask the LLM to generate IDs for new memories: it is ignored
anyway.
- Removed the "NONE" action, so that the LLM does not need to parrot
back all the unchanged facts. That information was being discarded
anyway.
- Various prompt improvements:
- Make the examples follow the same format as the actual input.
- Removed fact examples that would be essentially meaningless without
context ("Discussed the new project").
- Provided examples of counter-factuals. For example,
"dislikes cheese pizza" is a valid fact which could be stored, and
that's very different from applying a "Favorite kind of pizza is not
cheese" fact by deleting contradictory information.
- Do not give instructions like "you found from publicly
available sources on internet" which might not be true and therefore
might be dishonest.
- Make sure the wording style of the memories matches, between the
prompts (no "user is" redundant wording)
- Avoid ambiguity: "cheese and chicken pizza" vs "cheese pizza and
chicken pizza".
- Replace excess & ambiguous language ("pick", "Please keep in mind",
should vs must, etc.)
|
|
WalkthroughMinor updates in Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
|
Comment on lines
161
to
162
| except Exception as e: | ||
| logging.error(f"Error in new_retrieved_facts: {e}") |
There was a problem hiding this comment.
Error log message references incorrect variable name new_retrieved_facts instead of new_generated_facts, causing misleading error messages
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| except Exception as e: | |
| logging.error(f"Error in new_retrieved_facts: {e}") | |
| except Exception as e: | |
| logging.error(f"Error in new_generated_facts: {e}") |
WalkthroughMinor updates in Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
|
Comment on lines
161
to
162
| except Exception as e: | ||
| logging.error(f"Error in new_retrieved_facts: {e}") |
There was a problem hiding this comment.
Error log message references incorrect variable name new_retrieved_facts instead of new_generated_facts, causing misleading error messages
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| except Exception as e: | |
| logging.error(f"Error in new_retrieved_facts: {e}") | |
| except Exception as e: | |
| logging.error(f"Error in new_generated_facts: {e}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add()method does more than add: it may actually result in adds, updates, or deletes.Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist