improve input validation

membraneframework · Aug 29, 2024 · c0090e1 · c0090e1
1 parent 91bff32
commit c0090e1
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/boombox.ex b/lib/boombox.ex
@@ -36,9 +36,12 @@ defmodule Boombox do
 
   @spec run(Enumerable.t(), input: input, output: output) :: :ok | Enumerable.t()
   def run(stream \\ nil, opts) do
-    opts =
-      Keyword.validate!(opts, [:input, :output])
-      |> Map.new(fn {k, v} -> {k, parse_opt!(k, v)} end)
+    opts_keys = [:input, :output]
+    opts = Keyword.validate!(opts, opts_keys) |> Map.new(fn {k, v} -> {k, parse_opt!(k, v)} end)
+
+    if key = Enum.find(opts_keys, fn k -> not is_map_key(opts, k) end) do
+      raise "#{key} is not provided"
+    end
 
     case opts do
       %{input: {:stream, _in_stream_opts}, output: {:stream, _out_stream_opts}} ->