Fix null terminator at the end of DHCP option value

memphisraynz · Mar 9, 2018 · 376af38 · 376af38
1 parent 66a6fae
commit 376af38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/ManagementExtension-Samples/DOScript/Register-DOScript-AppPackage.ps1 b/ManagementExtension-Samples/DOScript/Register-DOScript-AppPackage.ps1
@@ -28,7 +28,7 @@ else {
         New-Item -Type String -Path $registryPath | Out-Null
     }
     $Name = "DOGroupId"
-    $value = $optionIdValue
+    $value = $optionIdValue.SubString(0, $optionIdValue.Length - 1)
     New-ItemProperty -Path $registryPath -Name $name -Value $value -PropertyType string -Force | Out-Null
   }
 }

diff --git a/ManagementExtension-Samples/DOScript/Register-DOScript.ps1 b/ManagementExtension-Samples/DOScript/Register-DOScript.ps1
@@ -1,13 +1,14 @@
 <#
-Version: 1.0
+Version: 1.1
 Author: Oliver Kieselbach
 Script: Register-DOScript.ps1
 
 Description:
 Register a PS script as scheduled task to query DHCP for option 234 to get Group ID GUID
 
 Release notes:
-Version 1.0: Original published version. 
+Version 1.0: Original published version.
+Version 1.1: Fix, removed null terminator at the end of DHCP option value provided by DHCPOption.exe
 
 The script is provided "AS IS" with no warranties.
 #>
@@ -70,7 +71,7 @@ else {
         New-Item -Type String -Path $registryPath | Out-Null
     }
     $Name = "DOGroupId"
-    $value = $optionIdValue
+    $value = $optionIdValue.SubString(0, $optionIdValue.Length - 1)
     New-ItemProperty -Path $registryPath -Name $name -Value $value -PropertyType string -Force | Out-Null
   }
 }