Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON-RPC v2 errors #103

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix JSON-RPC v2 errors #103

merged 2 commits into from
Nov 14, 2024

Conversation

junderw
Copy link
Member

@junderw junderw commented Sep 14, 2024

Fixes #102

@wiz
Copy link
Member

wiz commented Nov 7, 2024

request review by @mononaut

mononaut
mononaut approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@mononaut mononaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ [277b05b]

JSON-RPC errors are now returned in the proper format, and valid JSON-RPC requests still work ok.

@wiz wiz merged commit c6a7fbd into mempool Nov 14, 2024
7 checks passed
@wiz wiz deleted the junderw/json-rpc-2 branch November 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mononaut mononaut mononaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-RPC errors are sent as string instead of object, not following JSON-RPC spec
3 participants
@junderw @wiz @mononaut