Bulk txs outspends #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
approved these changes
Aug 15, 2023
|
Okay but we can rename all the APIs in a separate PR that adds the nginx stuff |
|
Sure. |
This was referenced Aug 16, 2023
|
See mempool/mempool#4158 (comment) Change internal API root to |
|
@mononaut Are you going to change this to /internal as well? |
|
no, this is the endpoint we want to use in the front end, so it needs to stay publicly accessible. it should be safe enough though, since it's capped at 50 txids per request and fails fast above that (and it'll replace a proxied nodejs endpoint that currently unrolls into 50 separate electrs /outspend requests) |
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
Bulk txs outspends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new bulk outspends endpoint at GET
/txs/outspends, which takes a comma-separated list of up to 50 txids in the?txidsquery param, and returns a nested list of outspends.The response matches the format of the equivalent
/api/v1/outspendsAPI endpoint in the mempool backend, and provides an easy and more efficient replacement for that API call.Note that the query param format is slightly different -- comma-separated values instead of php-style
foo[]=bararray syntax -- since the latter is awkward to parse.