Fix: Output index should be u32 to prevent clobbering when over 65536 outputs. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
force-pushed
the
junderw/fix-vout-u32
branch
from
602c653 to
5b2075b
Compare
mononaut
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Tested ACK @ 5b2075b
I manually deleted the db on testnet, successfully reindexed, and confirmed that it stays up after new blocks, address lookups etc. Also checked that all of the major API endpoints still work as expected.
The excessive output bug actually didn't reproduce on master in my local environment, so I wasn't able to confirm this fixes that.
I also have not tested Liquid assets, which this PR seems to touch.
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Feb 15, 2024
Bitcoin's consensus rules allows for output indexes larger than u16, which would result in an overflow prior to this fix. This recently happened with a transaction on testnet: https://blockstream.info/testnet/tx/ca3b75556430e1adf9e9790bce9c73a3d9afdb42305588e64c65b258c06c05c9 Based on @junderw's mempool/electrs#75. Thanks! This change requires a full database reindex.
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Feb 20, 2024
Bitcoin's consensus rules allows for output indexes larger than u16, which would result in an overflow prior to this fix. This recently happened with a transaction on testnet: https://blockstream.info/testnet/tx/ca3b75556430e1adf9e9790bce9c73a3d9afdb42305588e64c65b258c06c05c9 Based on @junderw's mempool/electrs#75. Thanks! This change requires a full database reindex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: REQUIRES RE-INDEX!!!!
Problem: If tx has over 16 bits of outputs, the indexing will clobber index 0 with index 65536 and so on.
Solution: 4 billion outputs is impossible without a hard fork. Use u32.