[FIR-125] feat(scrapeURL): add encodeRawHTML transformer for charset handling #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftonato
force-pushed
the
feat/encode-to-utf8
branch
from
420506f to
652f209
Compare
mogery
requested changes
Dec 28, 2024
| return document; | ||
| } | ||
| } catch (error) { | ||
| throw new Error("Failed to convert rawHtml to UTF-8"); |
There was a problem hiding this comment.
Always add the source error to the error object, so we can see the true error in the logs.
Suggested change
| throw new Error("Failed to convert rawHtml to UTF-8"); | |
| throw new Error("Failed to convert rawHtml to UTF-8", { cause: error }); |
Comment on lines
+48
to
+55
| try { | ||
| // Convert the response data if charset is not UTF-8 | ||
| if (charset.toUpperCase() !== "UTF-8") { | ||
| const decoder = new TextDecoder(charset); | ||
| document.rawHtml = decoder.decode(data); | ||
|
|
||
| return document; | ||
| } |
There was a problem hiding this comment.
The approach is good, but I think we need to move it to earlier parts of the stack, since the UTF-8 misencode is too destructive to get usable Shift_JIS out of just the parsed string. We need to move it up to a part of the code where we still have access to the raw buffer coming out of the network stack. Let's talk about this on Monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.