Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/web view native request method headers #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wilcomx
Copy link

@wilcomx wilcomx commented Jan 21, 2025

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR request adds GET (default) and POST (with optional body) method verb selection and header pass-through to the request url of the native WebView. Since url's are limited in lenght, so is the amount of additional data to pass along the request through query parameters. For example JWT's or other authentication and authorization information.

Relevant changes

This feature has added three configuration items to the advanced section of the WebView widget configuration:

  • GET and POST method verb selection.
  • An optional dynamic Body string to pass along with POST requests.
  • An optional object list with dynamic headerName and headerValue attributes.

All changes are backwards compitable and won't break the configurations of the previous version of the widget. On Android headers are only passed through GET requests. This is mentioned in the header description.

What should be covered while testing?

6 scenario's have been test on both Android and iOS:

  • GET request (previous and default working)
  • GET request with headers
  • POST request
  • POST request with body
  • POST request with headers (only supported on iOS)
  • POST request with body and headers (only supported on iOS)

Extra comments

Unit tests included and code coverage maintained. Applied formatting and lint.

@wilcomx wilcomx requested a review from a team as a code owner January 21, 2025 09:06
@wilcomx wilcomx changed the title Feat/web view native request method headers feat/web view native request method headers Jan 21, 2025
@UrazAkgultan
Copy link
Collaborator

Looks good to me 👍 Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants