[WC-2757] show numbers of rows pagination for virtual scrolling and load more #1392
+140
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
2 times, most recently
from
edd40dc to
a79af4d
Compare
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
from
a79af4d to
f2fe6a0
Compare
| @@ -1428,13 +1428,13 @@ exports[`Table with selection method checkbox render an extra column and add cla | |||
| <span | |||
| class="sr-only sr-only-focusable" | |||
| > | |||
| Currently showing 11 to 20 | |||
| Currently showing 11 to 0 | |||
There was a problem hiding this comment.
This new snapshot seems to be incorrect.
| @@ -1154,7 +1154,7 @@ exports[`Table renders the structure correctly with sorting 1`] = ` | |||
| class="test widget-datagrid" | |||
| > | |||
| <div | |||
| class="widget-datagrid-content sticky-table-container infinite-loading" | |||
| class="widget-datagrid-content sticky-table-container" | |||
There was a problem hiding this comment.
Are we removing this class?
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
from
f2fe6a0 to
d51c4e9
Compare
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
from
bdd248b to
d51c4e9
Compare
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
2 times, most recently
from
702a692 to
58e4634
Compare
gjulivan
force-pushed
the
WC-2757-dg-pagination
branch
from
58e4634 to
acf0349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description