feat: move away from constants

mento-protocol · Aug 18, 2024 · 249120c · 249120c
1 parent 5649ed3
commit 249120c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/script/upgrades/TemplateCelo/TemplateCelo.sol b/script/upgrades/TemplateCelo/TemplateCelo.sol
@@ -5,10 +5,13 @@ import { CeloGovernanceScript } from "script/utils/v2/CeloGovernanceScript.sol";
 
 contract TemplateCelo is CeloGovernanceScript {
   bool public constant override hasChecks = true;
-  // TODO: Add the description URL.
-  string public constant DESCRIPTION_URL = "Template For Celo Governance Proposals";
 
-  constructor() CeloGovernanceScript(DESCRIPTION_URL) {}
+  constructor()
+    CeloGovernanceScript(
+      // TODO: Add the URL from celo-org/governance.
+      "todo: Proposal URL"
+    )
+  {}
 
   function setUp() internal override {
     // TODO: Load any deployments scripts needed.

diff --git a/script/upgrades/TemplateMento/TemplateMento.sol b/script/upgrades/TemplateMento/TemplateMento.sol
@@ -5,12 +5,15 @@ import { MentoGovernanceScript } from "script/utils/v2/MentoGovernanceScript.sol
 
 contract TemplateMento is MentoGovernanceScript {
   bool public constant override hasChecks = true;
-  // TODO: Add the proposal title.
-  string public constant TITLE = "Template for Mento Governance Proposals";
-  // TODO: Add the path to the description markdown.
-  string public constant DESCRIPTION_PATH = "script/upgrades/TemplateMento/TemplateMento.md";
 
-  constructor() MentoGovernanceScript(TITLE, DESCRIPTION_PATH) {}
+  constructor()
+    MentoGovernanceScript(
+      // TODO: Add the proposal title.
+      "todo: Proposal Title",
+      // TODO: Add the path to the description markdown.
+      "script/upgrades/TemplateMento/TemplateMento.md"
+    )
+  {}
 
   function setUp() internal override {
     super.setUp();

diff --git a/script/utils/v2/CeloGovernanceScript.sol b/script/utils/v2/CeloGovernanceScript.sol
@@ -68,7 +68,7 @@ abstract contract CeloGovernanceScript is GovernanceScript {
         revert("Failed to simulate the proposal");
       }
     }
-    console.log("Proposal was simulated successfully.");
+    console.log(unicode"  Governance proposal simulated successfully.");
     vm.stopPrank();
   }