Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bash scripts to work for both governances #197

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

baroooo
Copy link
Contributor

@baroooo baroooo commented Jul 15, 2024

Description

Updates bash scripts to work with both Celo and Mento governances at the same time by introducing a new flag "-g".
If the governance is "celo", everything should work as before
If the governance is "mento", util scripts under "/mento" subfolder should be used to perform operations on the Mento Governance

Other changes

Removed some unused flags and updated some related comments in bash scripts

Tested

Tested by running MUGOV on Celo gov
Mento gov side can not be tested until the rest of the scripts are created

Related issues

Backwards compatibility

Compatible

Copy link
Contributor

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bayological bayological left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@chapati23 chapati23 merged commit a90f433 into main Jul 18, 2024
1 check passed
@chapati23 chapati23 deleted the feat-update-bs-to-work-with-mento-gov branch July 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants