Feat: PUSO gov script #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbow61
reviewed
Aug 20, 2024
philbow61
reviewed
Aug 20, 2024
denviljclarke
requested review from
a team,
bowd,
nvtaveras and
philbow61
and removed request for
a team
philbow61
requested changes
Aug 21, 2024
philbow61
approved these changes
Aug 22, 2024
bowd
approved these changes
Aug 26, 2024
script/upgrades/PUSO/Config.sol
Outdated
Comment on lines
91
to
93
| if (Chain.isBaklava() || Chain.isAlfajores()) { | ||
| poolConfig.minimumReports = 1; | ||
| } |
Comment on lines
197
to
205
| function assertApproxEq(uint256 a, uint256 b, uint256 maxDelta) internal view { | ||
| uint256 delta = a > b ? a - b : b - a; | ||
|
|
||
| if (delta > maxDelta) { | ||
| console.log("Diff(%s) between amounts is greater than %s", delta, maxDelta); | ||
| } | ||
|
|
||
| require(delta <= maxDelta, "Values are not approximately equal. See logs for more information."); | ||
| } |
There was a problem hiding this comment.
Does the assertApproxEq from forge-std/Test.sol not work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the upgrade scripts for the governance proposals to enable PUSO. Checks have been added, and fork tests have been updated and are green.
For Reviewers
For the swap tests to run, you can run the new RelayerReport script to relay rates to
SortedOracleson Alfajores/Baklava.Other changes
Tested
Related issues
Backwards compatibility
Documentation