Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert uint ts 2 str #213

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat: convert uint ts 2 str #213

merged 1 commit into from
Sep 3, 2024

Conversation

baroooo
Copy link
Contributor

@baroooo baroooo commented Sep 3, 2024

Description

We were not properly encoding the TS to string before for testnet proposals, which was causing buggy proposal names for testnet proposals.

image

This pr fixes that issue by using the uint2str function.

Other changes

no

Tested

image

Related issues

  • Not tracked

@baroooo baroooo requested review from a team, bowd, philbow61 and chapati23 and removed request for a team and bowd September 3, 2024 13:22
Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤩

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wao

Copy link
Contributor

@philbow61 philbow61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@baroooo baroooo merged commit 65a0700 into main Sep 3, 2024
1 check passed
@baroooo baroooo deleted the fix-timestamp-encoding-issue branch September 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants