feat: $cCOP launch deployment scripts #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvtaveras
commented
Oct 11, 2024
nvtaveras
commented
Oct 11, 2024
nvtaveras
commented
Oct 11, 2024
| @@ -40,7 +40,8 @@ library cCOPConfig { | |||
| * @dev Returns the configuration for the COPUSD rate feed. | |||
| */ | |||
| function COPUSD_RateFeedConfig() internal pure returns (Config.RateFeed memory rateFeedConfig) { | |||
| // TODO: Get the final circuit breaker configuration values from Roman and update them below. | |||
| // TODO: Get confirmation for Roman that these are OK | |||
| // These are the exact same as the $PUSO rate feed config | |||
There was a problem hiding this comment.
@rcroessmann Didn't update any of the circuit breaker parameters below
nvtaveras
commented
Oct 11, 2024
| asset1limits: Config.TradingLimit({ | ||
| enabled0: true, | ||
| timeStep0: 5 minutes, | ||
| limit0: 4211 * 200_000, |
There was a problem hiding this comment.
@rcroessmann Took this rate from the chainlink COP/USD aggregator directly https://celoscan.io/address/0x97b770B0200CCe161907a9cbe0C6B177679f8F7C#readContract
philbow61
reviewed
Oct 14, 2024
bayological
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the deployment script for launching $cCOP. Because it's essentially taking the same scripts we have written from previous deployments (in this case I took $PUSO as the base), I divided this into mostly 4 commits:
In this way, you can essentially review all commits after the first one independently to look at the smaller diff created when adjusting the $PUSO scripts, instead of the full blown overall changes of the PR.
Things left to do before this can be merged:
Tested
Not yet tested/simulated as the relayers are not yet deployed due to an issue on Alfajores when trying to deploy a contract using forno.
Related issues