fix: override the connect kit loader with a sync one #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security fix to altogether remove the exploit path that existed in
@ledgerhq/connect-kit-loader.This replaces the package with a version built from source and published at
https://github.com/mento-protocol/ledgerhq-connect-kit-loader-retrofittemporarily until, hopefully ledger merges and releases a retrofitted version to NPM.Details on the retrofit here: LedgerHQ/connect-kit#42
Basically completely remove the async loading part and just serve the dependency, but keep the interface of the
loaderin order to be able to replace it like we are doing here.Other changes
N/A
Tested
Built locally
Related issues
N/A
Checklist before requesting a review