Fix: wallet connect stale storage issue #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the code to include a function that cleans up stale wallet sessions. The function removes wallet sessions older than 1 hour from localStorage. This is necessary to resolve issues with corrupted walletconnect data causing problems with wallet connections. Changes: - Added `cleanupStaleWalletSessions` function to `src/config/wallets.ts` - Updated `ConnectButton.tsx` and `NetworkModal.tsx` to call `cleanupStaleWalletSessions` when necessary
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bayological
requested review from
a team,
nvtaveras,
Andrew718PLTS,
denviljclarke and
philbow61
and removed request for
a team,
nvtaveras and
Andrew718PLTS
Andrew718PLTS
requested changes
Nov 6, 2024
|
It works and looks good to me |
Andrew718PLTS
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue where users could not use a safe to execute transactions. This surfaced with a recent bug reported by RefiMedellin(https://discord.com/channels/966739027782955068/1302704425948807179).
Multiple compounding issues are causing the bug. During investigation and troubleshooting, it was discovered that one of the problems was an invalid WalletConnect state in the local storage (more info here).
This change will clear all items in local storage, from wallet connect, when the user connects. This does not fully resolve the bug, as it seems the reported issue is directly related to cCOP/cUSD, but will prevent this specific issue from occurring again.
Other changes
Tested
wc-safe-bug.webm
Related issues
Checklist before requesting a review