Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade swr and fix tests #118

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: upgrade swr and fix tests #118

merged 3 commits into from
Oct 11, 2024

Conversation

baroooo
Copy link
Contributor

@baroooo baroooo commented Oct 9, 2024

Description

Fixes the local development issues by upgrading swr package and some required changes related to this upgrade.
This pr also fixes the unit tests and sets up github actions to run test with PRs

Other changes

no

Related issues

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reserve-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:21am

@baroooo baroooo marked this pull request as ready for review October 10, 2024 13:36
@baroooo baroooo requested review from a team, RyRy79261, philbow61 and denviljclarke and removed request for a team and philbow61 October 10, 2024 13:38
Copy link
Member

@bayological bayological left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baroooo baroooo merged commit 4738c1d into main Oct 11, 2024
5 checks passed
@baroooo baroooo deleted the fix/local-development-issues branch October 11, 2024 12:48
Copy link

sentry-io bot commented Oct 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) ee(chunks/pages/index) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local development issues
4 participants