Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Pair to data_feed; changing impact config #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Pair to data_feed; changing impact config #226

wants to merge 1 commit into from

Conversation

sissnad
Copy link
Contributor

@sissnad sissnad commented Jul 22, 2022 •
edited
Loading

This PR includes:

  • a fix that adds parsing from string functionality to Pair to allow loading from data from files
  • ReflectiveSerializableEnum, an extension of SerializableEnum that adds __contains__() method for values
  • a change to the the parameter impacted assets: all CELO/Fiat pairs are included and BTC/Fiat, ETH/Fiat are excluded as Celo network impact is currently unlikely

tobikuhlmann
tobikuhlmann approved these changes Jul 22, 2022
View reviewed changes
Copy link

@tobikuhlmann tobikuhlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and tested simulation execution with different configs.

Just one question, do you think pair.py should live in /types/? Wondering as it's quite a class now with functionality, not just specifying types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobikuhlmann tobikuhlmann tobikuhlmann approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@bowd bowd

@tobikuhlmann tobikuhlmann

Labels
review me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sissnad @tobikuhlmann @bowd