Template healthcheck + integration test improvements and fixes #3616 #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- junit4 rule logic moved to IntegrationTestSupport class - junit4 rule uses now the integration test support - junit5 extension IntegrationTestExtension created + WithScenario annotation - junit5 extension uses also IntegrationTestSupport class
feature-3616-healthcheck-for-templates-and-assets
de-jcup
force-pushed
the
feature-3616-healthcheck-for-templates-and-assets
branch
from
c6e189f to
fb17a08
Compare
de-jcup
changed the title
- fixed failing TemplateRestControllerRestDocTest - added RestDoc test for template health checks
de-jcup
force-pushed
the
feature-3616-healthcheck-for-templates-and-assets
branch
from
31a1cde to
d122960
Compare
- restdoc test path problem fixed (was wrong usecase) - template servcie + config service + repository added missing implementation + tests to find all project ids which uses a template - Existing integration test for templates extended with healthcheck parts (scenario1). Has no errors in output because products do not support templates, so no conflict detected (correct) - Created new test (scenario9) for templates which fails with errors because product does support templates...
de-jcup
force-pushed
the
feature-3616-healthcheck-for-templates-and-assets
branch
from
d122960 to
1c7578d
Compare
- some integration test parts were executed in normal test phase and failed because no server available at this time on CI builds The junit5 extension does now full automatically prevent also afterAll, afterEach, beforeAll, beforeAch methods to be executed when integration tests are not enabled. - the failing Junit4 test was changed to Junit5 test which fixed the problem here as well. - documented the integration tests inside coding conventions documentation
de-jcup
force-pushed
the
feature-3616-healthcheck-for-templates-and-assets
branch
from
4f422e7 to
495d6be
Compare
- integration tests now depend on cleanIntegrationTest task to remove old junit results (skipped results are still results for gradle and new output does not appear /is collected...)
de-jcup
force-pushed
the
feature-3616-healthcheck-for-templates-and-assets
branch
from
495d6be to
1898929
Compare
winzj
approved these changes
Feb 3, 2025
- templates overview action added - templates delete action added - templates health check action added - added missing template ids to DeveloperProjectDetailInformation class - refactored templates health check service (huge method separated) - improved parts of documentation + fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR