Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI narrative revisions #329

Merged
merged 14 commits into from
Apr 6, 2020
Merged

Conversation

lwjohnst86
Copy link
Contributor

Closes #301.

@lwjohnst86 lwjohnst86 added the RSE Python Tasks for the RSE Python book label Feb 19, 2020
@lwjohnst86
Copy link
Contributor Author

Who is good with CI? Still need a reviewer for this. @k8hertweck do you know or can you assign someone this? Its not complete, but depends on the previous chapters in order to finish. So we could merge it in for now after someone has reviewed it.

@joelostblom
Copy link
Contributor

I am not comfortable enough with CI to review this, and I don't have enough time to read up on it thoroughly. Could we add this to next week's meeting agenda and maybe ping some people directly now already to have responses by next meeting?

@k8hertweck
Copy link
Contributor

I added this to the agenda, and pinged Slack with a note that someone with CI should review (unfortunately not me, I can potentially reach out to the rest of my community though)

@gvwilson gvwilson self-assigned this Mar 16, 2020
@gvwilson gvwilson self-requested a review March 16, 2020 14:03
Copy link
Contributor

@gvwilson gvwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (a few nitpicks about use of exclamation! marks!). There are a few FIXME markers still in this chapter - are they going to be filled in on this pass?

keypoints/rse-ci.md Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
py-rse/ci.Rmd Outdated Show resolved Hide resolved
please explain what keys like `before_cache` are about
and provide a diagram showing what files are produced and copied where.
Continuous integration was invented for testing,
but it can be used to automate almost anything.

FIXME: Add an example for deployment Python projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to be done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone wants to add to this, sure, otherwise we can remove it.

@lwjohnst86
Copy link
Contributor Author

@gvwilson let me know if you approve then we can merge in :)

@lwjohnst86 lwjohnst86 merged commit 539100e into merely-useful:book Apr 6, 2020
@lwjohnst86 lwjohnst86 deleted the ci-narrative branch July 23, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RSE Python Tasks for the RSE Python book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous Integration exercises
4 participants