-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI narrative revisions #329
Conversation
Who is good with CI? Still need a reviewer for this. @k8hertweck do you know or can you assign someone this? Its not complete, but depends on the previous chapters in order to finish. So we could merge it in for now after someone has reviewed it. |
I am not comfortable enough with CI to review this, and I don't have enough time to read up on it thoroughly. Could we add this to next week's meeting agenda and maybe ping some people directly now already to have responses by next meeting? |
I added this to the agenda, and pinged Slack with a note that someone with CI should review (unfortunately not me, I can potentially reach out to the rest of my community though) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (a few nitpicks about use of exclamation! marks!). There are a few FIXME markers still in this chapter - are they going to be filled in on this pass?
please explain what keys like `before_cache` are about | ||
and provide a diagram showing what files are produced and copied where. | ||
Continuous integration was invented for testing, | ||
but it can be used to automate almost anything. | ||
|
||
FIXME: Add an example for deployment Python projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still need to be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone wants to add to this, sure, otherwise we can remove it.
@gvwilson let me know if you approve then we can merge in :) |
Closes #301.