-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Architecture/fix] Throw explicit error for invalid configuration causing overlapping nodes #6176
base: develop
Are you sure you want to change the base?
[Architecture/fix] Throw explicit error for invalid configuration causing overlapping nodes #6176
Conversation
…ne side of a service
…to 6120/architecture-node-overlap
🦋 Changeset detectedLatest commit: 09da4bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6176 +/- ##
==========================================
- Coverage 4.47% 4.47% -0.01%
==========================================
Files 384 385 +1
Lines 54179 54207 +28
Branches 623 598 -25
==========================================
Hits 2425 2425
- Misses 51754 51782 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…to 6120/architecture-node-overlap
…icolasNewman/mermaid into 6120/architecture-node-overlap
📑 Summary
To avoid user confusion, Architecture diagrams now explicitly throw an error if two services attempt to connect to the same side of another service.
Resolves #6120
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.