Power graph #1556
Merged
Power graph #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of min and max entries.
…ist-ordinal combo.
…i in the TimeLabels composable.
…on allows for generic options.
… the legend data to instead display current and voltage.
|
Looks awesome |
|
Low priority but can you change all the blue colour elements to slightly brighter? It's a little hard to make out the blue text in dark mode on phones. |
Update
|
|
Excellent. Thank you. |
jamesarich
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
First iteration of the Power Metrics Graph.
Refactor
Made the time frame selector generic to accommodate selecting what power channel we wish to plot.
Demo
mock data
power_graph_demo.mp4