Support for M5Stack Core2 ESP32 #5043
Open
+248
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lboue
added a commit
to lboue/meshtastic_firmware
that referenced
this pull request
Oct 13, 2024
DataRegion struct from meshtastic#5043 PR
|
@thebentern |
|
This time |
caveman99
requested changes
Oct 14, 2024
| pinMode(TFT_BL, OUTPUT); | ||
| digitalWrite(TFT_BL, HIGH); | ||
| #endif | ||
| #if defined(M5STACK_CORE2) |
There was a problem hiding this comment.
TFT_BL is defined in a lot of other variants and usually handled by the driver internally. please check if this is neccessary and does not affect other platforms
There was a problem hiding this comment.
Thanks, I'll make it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for M5Stack Core2 ESP32 because we no longer have an answer in PR #4471.