Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename M5STACK_CORE to prepare for M5STACK_CORE2 and M5STACK_CORES3 #598

Closed
wants to merge 1 commit into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 9, 2024

What does this PR do?

Rename to M5STACK_CORE to prepare for M5STACK_CORE2 and M5STACK_CORES3

Related PR

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

Rename M5STACK_CORE to prepare for M5STACK_CORE2 and M5STACK_CORES3
@andrekir
Copy link
Member

andrekir commented Oct 9, 2024

unfortunately changing the HardwareModel enum name is a breaking change for Android (#442)

@lboue
Copy link
Contributor Author

lboue commented Oct 10, 2024

OK.

@lboue lboue closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants