Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dedupe images to reduce airgapped bundle size #1469

Merged
merged 7 commits into from
Nov 10, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Nov 8, 2023

What type of PR is this?

feat

What this PR does/ why we need it:

Dedupe common images across apps to keep airgapped image bundle size down

Which issue(s) this PR fixes:

D2IQ-99209

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Nov 8, 2023
To avoid having to bump kubectl in all apps in k-apps, it would be
easier to just align to the existing image in k-apps for now, in case
there are errors with the newer version.
CI is failing, revert for now to tackle in separate PR.
@gracedo gracedo added the ready ready label Nov 8, 2023
@gracedo gracedo self-assigned this Nov 8, 2023
@gracedo gracedo marked this pull request as ready for review November 8, 2023 23:18
@gracedo gracedo requested review from a team as code owners November 8, 2023 23:18
Copy link
Contributor

@tillt tillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gracedo gracedo merged commit 6135b0d into mesosphere:master Nov 10, 2023
3 of 5 checks passed
@gracedo gracedo deleted the bcm/dedup-images branch November 10, 2023 01:04
d2iq-mergebot pushed a commit that referenced this pull request Nov 10, 2023
… Dedupe images to reduce airgapped bundle size * chore: Bump charts * fix: don't specify prometheus and kube-state-metrics tags * chore: try with kube-state-metrics v2.9.2 * feat(kubecost): Update thanos image to 0.32.5 * fix: Use kubectl 1.26.4 To avoid having to bump kubectl in all apps in k-apps, it would be easier to just align to the existing image in k-apps for now, in case there are errors with the newer version. * fix(kubecost): Revert image updates CI is failing, revert for now to tackle in separate PR. --------- Co-authored-by: Brian Mendoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants