-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Dedupe images to reduce airgapped bundle size #1469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
added
the
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
label
Nov 8, 2023
To avoid having to bump kubectl in all apps in k-apps, it would be easier to just align to the existing image in k-apps for now, in case there are errors with the newer version.
gracedo
force-pushed
the
bcm/dedup-images
branch
from
November 8, 2023 21:38
0d947ef
to
722c7c9
Compare
CI is failing, revert for now to tackle in separate PR.
6 tasks
tillt
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mikolajb
approved these changes
Nov 9, 2023
d2iq-mergebot
pushed a commit
that referenced
this pull request
Nov 10, 2023
… Dedupe images to reduce airgapped bundle size * chore: Bump charts * fix: don't specify prometheus and kube-state-metrics tags * chore: try with kube-state-metrics v2.9.2 * feat(kubecost): Update thanos image to 0.32.5 * fix: Use kubectl 1.26.4 To avoid having to bump kubectl in all apps in k-apps, it would be easier to just align to the existing image in k-apps for now, in case there are errors with the newer version. * fix(kubecost): Revert image updates CI is failing, revert for now to tackle in separate PR. --------- Co-authored-by: Brian Mendoza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does/ why we need it:
Dedupe common images across apps to keep airgapped image bundle size down
Which issue(s) this PR fixes:
D2IQ-99209
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist