Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a rebuilt cosi-controller image #1542

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

dkoshkin
Copy link
Contributor

What type of PR is this?

Chore

What this PR does/ why we need it:

The upstream repository will be removed.
The image was re-built as part of mesosphere/dkp-container-images#14

Which issue(s) this PR fixes:

https://jira.nutanix.com/browse/NCN-105277

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@dkoshkin dkoshkin requested review from a team as code owners January 22, 2025 22:28
No need to include the namespace, Helm will create it.
This also fixes the upgrade tests not being able to import the namespace.
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-cosi-controller-rebuilt-image branch from 03b7a69 to 860321d Compare January 22, 2025 23:17
@dkoshkin dkoshkin changed the base branch from master to dkoshkin/fix-cosi-controller-namespace January 22, 2025 23:17
@dkoshkin
Copy link
Contributor Author

Stacked on #1543 to fix the namespace upgrade issue

Base automatically changed from dkoshkin/fix-cosi-controller-namespace to master January 23, 2025 09:20
@jimmidyson jimmidyson enabled auto-merge (squash) January 23, 2025 09:22
@jimmidyson jimmidyson merged commit 16d255c into master Jan 23, 2025
5 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/fix-cosi-controller-rebuilt-image branch January 23, 2025 09:25
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 24, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 25, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 27, 2025
takirala added a commit to takirala/charts that referenced this pull request Jan 28, 2025
dkoshkin added a commit to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix that referenced this pull request Feb 3, 2025
**What problem does this PR solve?**:
The `gcr.io/k8s-staging-sig-storage` repository is being shut down.
Temporarily moving the image until upstream moves it to a more permanent
location.

This pulls in the changes:
- mesosphere/charts#1542
- mesosphere/charts#1543

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->
The e2e tests will verify the controller is running.
I've also verified the image by following the examples in
https://github.com/nutanix-cloud-native/cosi-driver-nutanix

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants