feat: add cosi transformer for harbor and kubecost #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Gupta Akirala <[email protected]>
2 tasks
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
takirala
force-pushed
the
tga/cosi-bucket-kit-updates
branch
from
10508f7 to
351652e
Compare
2 tasks
takirala
changed the title
mhrabovcin
reviewed
Jan 27, 2025
mhrabovcin
reviewed
Jan 27, 2025
| --from-literal=REGISTRY_STORAGE_S3_SECRETKEY=$(kubectl get secret {{ .credentialsSecretName }} -n {{ $ns }} -o jsonpath="{.data.BucketInfo}" | base64 --decode | jq -r '.spec.secretS3.accessSecretKey') \ | ||
| --dry-run=client -o yaml | kubectl apply -f - | ||
| # Create a configmap with the name of the secret from above. | ||
| kubectl create configmap {{ $cmName }} -n {{ $ns }} \ |
There was a problem hiding this comment.
Suggested change
| kubectl create configmap {{ $cmName }} -n {{ $ns }} \ | |
| kubectl create configmap {{ $cmName }} -n kommander \ |
The overrides CM needs to be created in the ns of the harbor HelmRelease - in the kommander ns.
There was a problem hiding this comment.
Discussed offline and since this doesn't work on attached clusters, decided to add a new namespace param (mesosphere/kommander-applications@bd212e4)
mhrabovcin
reviewed
Jan 27, 2025
Co-authored-by: Martin Hrabovcin <[email protected]>
cwyl02
approved these changes
Jan 27, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
mhrabovcin
reviewed
Jan 27, 2025
Co-authored-by: Martin Hrabovcin <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…d-by: Martin Hrabovcin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add a cosi secret transformer for harbor
What this PR does/ why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist