Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: elevate cosi rbac #1546

Merged
merged 2 commits into from
Jan 28, 2025
Merged

chore: elevate cosi rbac #1546

merged 2 commits into from
Jan 28, 2025

Conversation

takirala
Copy link
Contributor

What type of PR is this?

Harbor needs configmap to be created in a namespace that is different than the namespace of the Helm release. This change upgrades Role to ClusterRole.

What this PR does/ why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala marked this pull request as ready for review January 28, 2025 00:15
@takirala takirala requested review from a team as code owners January 28, 2025 00:15
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@mhrabovcin mhrabovcin merged commit 6834b6e into master Jan 28, 2025
5 checks passed
@mhrabovcin mhrabovcin deleted the tga/cosi-bucket-kit-updates branch January 28, 2025 10:32
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
…f-by: Tarun Gupta Akirala <[email protected]> * fix: simplify heredoc format Signed-off-by: Tarun Gupta Akirala <[email protected]> --------- Signed-off-by: Tarun Gupta Akirala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants