Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add airgapped certification to istio, jaeger, and kiali #3044

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

nataliepina
Copy link
Contributor

What problem does this PR solve?:
Istio, Jaeger, and Kiali are available in airgapped environments.
Link to discussion - https://nutanix.slack.com/archives/C068HGFS19B/p1737181472843889

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105312

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Istio, Jaeger, and Kiali will have a badge indicating they are available in airgapped environments.

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 21, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/apps-missing-airgapped-cert

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12891004647

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12871382284: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Copy link
Contributor

@guillermoz-nutanix guillermoz-nutanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change only cosmetic?

I mean, how we decide if an app would make it to the final airgapped bundle? Can't we use the same data to show the corresponding badge, instead of having to keep two fields in sync?

Copy link
Contributor

@mhrabovcin mhrabovcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nataliepina !

@mhrabovcin mhrabovcin merged commit 298d7f9 into main Jan 22, 2025
117 of 120 checks passed
@mhrabovcin mhrabovcin deleted the apps-missing-airgapped-cert branch January 22, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/istio services/jaeger services/kiali size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants