-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add airgapped certification to istio, jaeger, and kiali #3044
Conversation
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/apps-missing-airgapped-cert |
Pull Request Test Coverage Report for Build 12891004647Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change only cosmetic?
I mean, how we decide if an app would make it to the final airgapped bundle? Can't we use the same data to show the corresponding badge, instead of having to keep two fields in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nataliepina !
What problem does this PR solve?:
Istio, Jaeger, and Kiali are available in airgapped environments.
Link to discussion - https://nutanix.slack.com/archives/C068HGFS19B/p1737181472843889
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105312
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist