Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump cert-manager 1.14.7 #2331

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat: bump cert-manager 1.14.7 #2331

merged 3 commits into from
Jul 2, 2024

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Jun 24, 2024

What problem does this PR solve?:
bump cert-manager to be consistent with konvoy

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-100545

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jun 24, 2024
@cwyl02 cwyl02 requested a review from a team June 24, 2024 14:19
@cwyl02 cwyl02 self-assigned this Jun 24, 2024
@cwyl02 cwyl02 added the let-me-merge-it Allow author of PR to merge it label Jun 24, 2024
@github-actions github-actions bot added services/cert-manager size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jun 24, 2024
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9647035461

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 9621579969: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/ychen/bump-cert-manager

@cwyl02 cwyl02 force-pushed the ychen/bump-cert-manager branch from a553e6b to c260895 Compare June 26, 2024 19:23
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9685554327

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 9683091529: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@cwyl02 cwyl02 force-pushed the ychen/bump-cert-manager branch from c260895 to c100ea6 Compare June 27, 2024 19:46
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9702686618

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 9686602310: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@cwyl02
Copy link
Contributor Author

cwyl02 commented Jul 2, 2024

we decided to bump to mesosphere/charts#1502 instead

@cwyl02 cwyl02 force-pushed the ychen/bump-cert-manager branch from 3c5d7b2 to b587564 Compare July 2, 2024 18:05
@cwyl02 cwyl02 changed the title feat: bump cert-manager 1.15.0 feat: bump cert-manager 1.14.7 Jul 2, 2024
@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9765861060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 9759017019: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9765863785

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 9759017019: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@cwyl02 cwyl02 added services/cert-manager and removed services/cert-manager ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jul 2, 2024
@cwyl02 cwyl02 added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Jul 2, 2024
@cwyl02 cwyl02 merged commit 9e7ca74 into main Jul 2, 2024
44 checks passed
@cwyl02 cwyl02 deleted the ychen/bump-cert-manager branch July 2, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracedo gracedo gracedo approved these changes

Assignees

@cwyl02 cwyl02

Labels
do-not-merge/testing Do not merge because there is still on-going testing let-me-merge-it Allow author of PR to merge it ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/cert-manager size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwyl02 @coveralls @gracedo @d2iq-mergebot