Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nutanix cosi driver app #3031

Merged
merged 11 commits into from
Jan 24, 2025
Merged

feat: add nutanix cosi driver app #3031

merged 11 commits into from
Jan 24, 2025

Conversation

takirala
Copy link
Contributor

What problem does this PR solve?:

Adds a new app definition for deploying https://github.com/nutanix-cloud-native/cosi-driver-nutanix/ as a platform app.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105272

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 17, 2025
@takirala takirala self-assigned this Jan 17, 2025
@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12946304140

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12945942450: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@takirala takirala force-pushed the tga/add-nutanix-cosi-driver branch from 83ba13c to 1553830 Compare January 21, 2025 19:50
@mesosphere-ci mesosphere-ci added do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/add-nutanix-cosi-driver

@takirala
fix: remove unnecessary params
fafd3f8 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala added ready-for-review and removed do-not-merge/testing Do not merge because there is still on-going testing labels Jan 21, 2025
@takirala takirala requested a review from jimmidyson January 21, 2025 20:06
@mesosphere-ci mesosphere-ci added the do-not-merge/testing Do not merge because there is still on-going testing label Jan 21, 2025
@takirala takirala removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/rook-ceph-cluster labels Jan 21, 2025
@takirala
chore: add image to license manifest
82b4132 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@mesosphere-ci mesosphere-ci added the open-kommander-pr Automatically triggers the creation of a PR in Kommander repo label Jan 21, 2025
@takirala takirala requested a review from a team January 22, 2025 16:32
@takirala takirala removed the do-not-merge/testing Do not merge because there is still on-going testing label Jan 22, 2025
@mesosphere-ci mesosphere-ci added the do-not-merge/testing Do not merge because there is still on-going testing label Jan 24, 2025
@takirala takirala merged commit 8b9c4e2 into main Jan 24, 2025
39 checks passed
@takirala takirala deleted the tga/add-nutanix-cosi-driver branch January 24, 2025 16:24
rohitkumar0510 pushed a commit that referenced this pull request Feb 5, 2025
@takirala @d2iq-mergebot @rohitkumar0510
feat: add nutanix cosi driver app (#3031)
ecbe39d 
Co-authored-by: d2iq-mergebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin approved these changes

@dkoshkin dkoshkin Awaiting requested review from dkoshkin

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

Assignees

@takirala takirala

Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/rook-ceph-cluster size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@takirala @coveralls @mhrabovcin @jimmidyson @mesosphere-ci @d2iq-mergebot