Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cosi & harbor metadata fields #3120

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kishankumarnutanix
Copy link
Contributor

@kishankumarnutanix kishankumarnutanix commented Feb 5, 2025

What problem does this PR solve?:
The category and the dependency field of metadata yaml of the cosi driver nutanix app and harbor app was set to empty array. However, we do not need dependency fields for either of the app and category needs to be general. Hence removing dependency field and adding category.
Slack Discussion Thread :- https://nutanix.slack.com/archives/C06A78Y063B/p1738775586636359?thread_ts=1738773226.964009&cid=C06A78Y063B

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105574

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/harbor services/cosi-driver-nutanix and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Feb 5, 2025
@kishankumarnutanix kishankumarnutanix force-pushed the kk/fix-cosi-harbor-metadata branch from d915f86 to 0e0ded1 Compare February 5, 2025 16:36
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2025
@kishankumarnutanix kishankumarnutanix self-assigned this Feb 5, 2025
@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13163592124

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13159470805: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@kishankumarnutanix kishankumarnutanix force-pushed the kk/fix-cosi-harbor-metadata branch from 0e0ded1 to 122b1e6 Compare February 5, 2025 17:58
@kishankumarnutanix kishankumarnutanix marked this pull request as ready for review February 5, 2025 17:59
@kishankumarnutanix kishankumarnutanix requested review from mhrabovcin and a team and removed request for a team February 5, 2025 19:43
@kishankumarnutanix kishankumarnutanix merged commit 55f4196 into main Feb 5, 2025
33 checks passed
@kishankumarnutanix kishankumarnutanix deleted the kk/fix-cosi-harbor-metadata branch February 5, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/cosi-driver-nutanix services/harbor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants