Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update root README with absolute path to fix https://pypi.org/project/llama-cookbook/ broken links #880

Merged
merged 2 commits into from
Feb 10, 2025
Merged

update root README with absolute path to fix https://pypi.org/project/llama-cookbook/ broken links #880

merged 2 commits into from
Feb 10, 2025

Conversation

IgorKasianenko
Copy link
Contributor

What does this PR do?

title

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@IgorKasianenko IgorKasianenko requested a review from mreso February 7, 2025 13:13
@IgorKasianenko IgorKasianenko self-assigned this Feb 7, 2025
@albertodepaola
Copy link
Contributor

This looks good and it's working, but how does having the absolute path fixes the pypi broken links?

@albertodepaola albertodepaola self-requested a review February 7, 2025 19:21
albertodepaola
albertodepaola approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@albertodepaola albertodepaola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@IgorKasianenko IgorKasianenko merged commit 4606c54 into meta-llama:main Feb 10, 2025
4 checks passed
@IgorKasianenko IgorKasianenko deleted the fix/update-readme-links branch February 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertodepaola albertodepaola albertodepaola approved these changes

@mreso mreso Awaiting requested review from mreso

Assignees

@IgorKasianenko IgorKasianenko

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgorKasianenko @albertodepaola @facebook-github-bot