Fix for retrive session in sync and async both #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanxi0830
requested changes
Oct 25, 2024
There was a problem hiding this comment.
The client SDK is auto-generated based on OpenAPI spec. This should be fixed with the server webmethod endpoint and OpenAPI spec instead.
So do you mean I should change the implementation on the server side in the llama stack repo or do I make changes in OpenAPI spec or both? |
|
@cheesecake100201 Yes, I think we should make sure (1) server side is also implemented as GET (2) OpenAPI spec is a GET (3) client SDK is a GET. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is occuring because, in the main implementation of this API endpoint, its a post request (Even though it should be a GET request) and agent_id and session_id are being passed in the body where as this method is sending it in query_params which is causing a 400 Error and a pydantic error of FASTAPI. This is a fix for now but might suggest converting fetching methods in implementation to be converted into GET methods in llama stack repo.