Feature/add platform to docker #263
Conversation
picografix
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
|
Hi @picografix! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -205,6 +210,8 @@ def _run_stack_build_command(self, args: argparse.Namespace) -> None: | |||
| build_config.name = args.name | |||
| if args.image_type: | |||
| build_config.image_type = args.image_type | |||
| if args.platform: # Add platform to build_config if provided | |||
There was a problem hiding this comment.
you can remove the comment, it is self-explanatory what the code is doing
| @@ -107,8 +108,9 @@ def build_image(build_config: BuildConfig, build_file_path: Path): | |||
| script, | |||
| build_config.name, | |||
| str(build_file_path), | |||
| " ".join(deps), | |||
| " ".join(deps) | |||
| @@ -5,7 +5,7 @@ LLAMA_STACK_DIR=${LLAMA_STACK_DIR:-} | |||
| TEST_PYPI_VERSION=${TEST_PYPI_VERSION:-} | |||
|
|
|||
| if [ "$#" -lt 4 ]; then | |||
There was a problem hiding this comment.
don't you need to change this?
| args = [ | ||
| script, | ||
| build_config.name, | ||
| package_deps.docker_image, | ||
| build_config.platform, |
Now you can specify
platformparam in the cmd argsllama stack build --template local --image-type docker --platform "linux/amd64" --name llama-stackresolves #253