Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update traffic light controller #804

Closed
wants to merge 1 commit into from
Closed

Conversation

DhlinV
Copy link
Collaborator

@DhlinV DhlinV commented Jan 20, 2025

What changes do you make in this PR?

  • Please describe why you create this PR
  • Vehicle can be controlled by traffic light, implemented by adding ghost vehicle when traffic light is red and replace the action by idm action
  • update module test 'metadrive/tests/test_component/test_traffic_light.py' to test the functionality
    Screencast from 01-20-2025 03:37:12 PM.webm

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@DhlinV DhlinV requested a review from QuanyiLi January 20, 2025 23:39
@QuanyiLi
Copy link
Member

Thank you for the PR.

I went through it already. I think It may not be the best implementation... Actually, the traffic light itself has a body, we can use it instead of the dummy vehicle. Just make it recognizable by the IDM policy, or specifically by the lidar. I am making a new PR to achieve this.

@DhlinV DhlinV closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants